Skip to content

London|26-ITP-January|Alexandru Pocovnicu|Sprint 3| Implement and rewrite#924

Open
alexandru-pocovnicu wants to merge 16 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu:coursework/sprint-3-implement-and-rewrite
Open

London|26-ITP-January|Alexandru Pocovnicu|Sprint 3| Implement and rewrite#924
alexandru-pocovnicu wants to merge 16 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu:coursework/sprint-3-implement-and-rewrite

Conversation

@alexandru-pocovnicu
Copy link

@alexandru-pocovnicu alexandru-pocovnicu commented Feb 1, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Done the exercises from sprint 3 implement and rewrite

@alexandru-pocovnicu
updated getAngleType to check for acute angle
0ae5f4b
@alexandru-pocovnicu
wrote test to check for obtuse angle and implemented the function to …
dc90d42 
…pass the test
@alexandru-pocovnicu
Implement logic to identify straight angles in getAngleType function
34d3bc5
@alexandru-pocovnicu
Implement logic to identify reflex angles in getAngleType function
023c553
@alexandru-pocovnicu
Add tests for obtuse angles in getAngleType function
c17f6c3
@alexandru-pocovnicu
added additional tests to check for a properr fraction and implemente…
c5b9e52 
…d the function accordingly
@alexandru-pocovnicu
assigned rang with the value of card[0]
9f3ed4f
@alexandru-pocovnicu
Implement logic to handle number and face cards in getCardValue function
366621c
@alexandru-pocovnicu
Refactor isProperFraction function to handle NaN inputs and improve l…
35c3083 
…ogic for proper fraction checks
@alexandru-pocovnicu
wrote tests to check cards validity and implemented the function to p…
83a3f77 
…ass the tests
@alexandru-pocovnicu
Add tests for angle type identification in getAngleType function
6c0b2c0
@alexandru-pocovnicu
Add validation for card input in getCardValue function
79fd501
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@alexandru-pocovnicu alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@alexandru-pocovnicu alexandru-pocovnicu changed the title London|26-ITP-January|Alexandru Pocovnicu|Coursework|sprint 3 implement and rewrite London|26-ITP-January|Alexandru Pocovnicu|Sprint 3| Implement and rewrite Feb 1, 2026
@alexandru-pocovnicu
Fix isProperFraction function to correctly handle equal absolute valu…
7049b83 
…es of numerator and denominator
@alexandru-pocovnicu
Add additional test cases for isProperFraction function to cover impr…
0492fb4 
…oper fractions, negative fractions, and equal numerator and denominator scenarios
@alexandru-pocovnicu alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alexandru-pocovnicu